Cleanup `process` in Combobox component when using virtualization

tailwindlabs / headlessui

Completely unstyled, fully accessible UI components, designed to integrate beautifully with Tailwind CSS.

https://headlessui.com

MIT License

25.81k stars 1.07k forks source link

Cleanup `process` in Combobox component when using virtualization #3495

Closed RobinMalfait closed 4 days ago

RobinMalfait commented 4 days ago

This PR is a different approach compared to #3487.

Instead of checking whether we are in a test environment (specifically in a Jest environment), I think we can just get rid of the check entirely and use the virtualizer in all environments.

This will remove an unnecessary check for process being available and gets rid of process entirely. It also fixes an issue that #3487 tries to solve where process is available, but process.env is not.

Closes: #3487

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headlessui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2024 9:43am
headlessui-vue	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2024 9:43am