Fix crash in `ListboxOptions` when using `as={Fragment}`

tailwindlabs / headlessui

Completely unstyled, fully accessible UI components, designed to integrate beautifully with Tailwind CSS.

https://headlessui.com

MIT License

26.28k stars 1.09k forks source link

Closed RobinMalfait closed 1 month ago

RobinMalfait commented 1 month ago

This PR fixes an issue where a Maximum update depth exceeded error occurs if you use as={Fragment} in the ListboxOptions component.

This PR also includes a refactor to make sure this exact issue cannot happen anymore in other components.

Fixes: #3507

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headlessui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 8, 2024 9:11pm
headlessui-vue	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 8, 2024 9:11pm