search

tailwindlabs / heroicons

A set of free MIT-licensed high-quality SVG icons for UI development.
https://heroicons.com
MIT License
21.36k stars 1.28k forks source link

_openBlock is not a function #229

Closed jhull closed 3 years ago

jhull commented 3 years ago

Getting this on new install:

 WARN  Compiled with 3 warnings                       friendly-errors 20:43:37

 WARN  in ./node_modules/@heroicons/vue/outline/esm/AcademicCapIcon.js

"export 'createBlock' (imported as '_createBlock') was not found in 'vue'
                                                      friendly-errors 20:43:37

 WARN  in ./node_modules/@heroicons/vue/outline/esm/AcademicCapIcon.js

"export 'createVNode' (imported as '_createVNode') was not found in 'vue'
                                                      friendly-errors 20:43:37

 WARN  in ./node_modules/@heroicons/vue/outline/esm/AcademicCapIcon.js

"export 'openBlock' (imported as '_openBlock') was not found in 'vue'
                                                      friendly-errors 20:43:37

using Nuxt-edge and "@heroicons/vue": "^1.0.0",

brianbirir commented 3 years ago

I get similar warnings and can't run the Nuxt app locally when I import an icon component e.g. XIcon:

 WARN  in ./node_modules/@heroicons/vue/solid/esm/AcademicCapIcon.js                     friendly-errors 13:53:17

"export 'createBlock' (imported as '_createBlock') was not found in 'vue'                friendly-errors 13:53:17
                                                                                         friendly-errors 13:53:17

 WARN  in ./node_modules/@heroicons/vue/solid/esm/AcademicCapIcon.js                     friendly-errors 13:53:17

"export 'createVNode' (imported as '_createVNode') was not found in 'vue'                friendly-errors 13:53:17
                                                                                         friendly-errors 13:53:17

 WARN  in ./node_modules/@heroicons/vue/solid/esm/AcademicCapIcon.js                     friendly-errors 13:53:17

"export 'openBlock' (imported as '_openBlock') was not found in 'vue'

Environment

Screenshot

Screenshot 2021-03-30 at 13 58 26

adamwathan commented 3 years ago

Sorry this is because our Vue library is for Vue 3 and your projects are using Vue 2. Unfortunately there are major BC breaks between Vue 2 and Vue 3 and we can't support both without creating an additional library.

Not totally opposed to it but probably can't prioritize it right away either I'm afraid 😞

brianbirir commented 3 years ago

@adamwathan thank you for the quick response. No problem; for now I've confirmed with my team that we'll use the SVG version of HeroIcons as we plan to migrate to Vue 3 at a later time.

jhull commented 3 years ago

Cool - it looked like this was a Vue 2/Vue 3 thing, but wasn't sure at the time (did I miss the Vue 3 only documentation?)

Still waiting on Nuxt to rollup Vue 3 so I'll stick to copy and paste for now :)