search

tailwindlabs / heroicons

A set of free MIT-licensed high-quality SVG icons for UI development.
https://heroicons.com
MIT License
21.36k stars 1.28k forks source link

Add Vue 2 support #235

Closed slovenianGooner closed 3 years ago

slovenianGooner commented 3 years ago

This pull request adds support to compile for Vue 2.

It adds another build script with transform for Vue 2 and it generates the necessary Vue 2 single file components for all the icons.

Also updated the readme file which demonstrates how to import a single icon.

divine commented 3 years ago

Well, two libraries will make things messy, why not use something like vue-demi?

Thanks!

appinteractive commented 3 years ago

Well, two libraries will make things messy, why not use something like vue-demi?

Thanks!

vue-demi does not help in that situation as we need different files not imports.

adamwathan commented 3 years ago

Hey thank you so much! I know I originally said I would welcome a PR for this, but it's become clear to me recently that we really have to be careful about what we commit to maintaining, and so I think for now this would best be handled as a third-party package. Heroicons are MIT licensed so you are totally welcome to publish this to npm and maintain it for the community if you like 👍

Sorry, hope that's understandable and thanks again regardless, really appreciate it ❤️