tailwindlabs / heroicons

A set of free MIT-licensed high-quality SVG icons for UI development.
https://heroicons.com
MIT License
21.02k stars 1.26k forks source link

Feedback: `check` icon #736

Closed jlalmes closed 1 year ago

jlalmes commented 1 year ago

Just upgraded to v2.0.0 looks great! 🎉🚀

I suppose this is just one person's opinion, but the new check icon is really jarring. Should we include the old v1 style check icon in v2 and introduce this as a new icon in v2 ie. swoosh?

Screenshot 2022-08-23 at 17 45 46

No hard feelings if you want to close this issue, but thought I'd share my initial thoughts.

Again v2 looks great, looking forward to using the updated iconset!

Soviut commented 1 year ago

I'm in favour of a straighter checkmark, but this would also require some consideration for the other icons that have a checkmark in them.

image

robclancy commented 1 year ago

I guess they are trying to make their icons have their own unique look a bit more. But that screenshot there with it beside other icons just makes the standalone one look bad.

denjaland commented 1 year ago

I like the new one when it's inside the other icons indeed; standalone I think I'd still prefer the straight one indeed. Just my 0.02

sschoger commented 1 year ago

Went ahead and made a straight checkmark. Was going to add it as an alternative but it felt weird that the curved one would be the default and the straight one would be the alternative so it felt necessary to apply this change to all of the icons:

CleanShot 2022-08-24 at 15 12 52@2x

Improvement?

Soviut commented 1 year ago

@sschoger Personally I think it's an improvement. On standard definition screens it seems to alias less than the more rounded one.

For example

image

denjaland commented 1 year ago

Much better imo 👌

jlalmes commented 1 year ago

Looks great @sschoger - thank you!

RobinMalfait commented 1 year ago

Hey! Thank you for your suggestion! Much appreciated! 🙏

This should be fixed by #762, and will is available in the next release (2.0.5).