search

tailwindlabs / heroicons

A set of free MIT-licensed high-quality SVG icons for UI development.
https://heroicons.com
MIT License
21.03k stars 1.27k forks source link

Add exports field #920

Closed thecrypticace closed 1 year ago

thecrypticace commented 1 year ago

Fixes #914

In most instances this isn't necessary except for SSR. And Vite even works around this problem for SSR bundles by doing some rewriting when the module is loaded. However, given that there are some places that need this it'll help make usage more consistent across environments.

You can no longer require() or import files directly from the package that are not covered by the exports field. However, all paths that were previously importable should be covered. We have covered the all components with and without an extension, the index file (with and without an extension), an implicit index export, legacy v1 imports, the package.json, etc…

blowsie commented 1 year ago

I beleive this commit breaks usage in nuxt3 with vite

thecrypticace commented 1 year ago

@blowsie can you open an issue with a reproduction please? It shouldn't be a breaking change.