tailwindlabs / tailwindcss-aspect-ratio

MIT License
972 stars 34 forks source link

mark tailwindcss as a peer dependency #14

Closed dominicm00 closed 3 years ago

dominicm00 commented 3 years ago

This plugin uses tailwindcss internally, but marks it only as a dev dependency rather than a peer dependency, causing errors/undefined behavior in monorepos and Yarn PNP. Correctly adding tailwind as a peer dependency allows for correct resolution to occur while still referencing the user's tailwind and not an internal version.

Other official plugins have already corrected this: see tailwindlabs/tailwindcss-forms@8a8671b

This pull request is identical to https://github.com/tailwindlabs/tailwindcss-line-clamp/pull/6. Both other official plugins (forms, typography) already correctly use peer dependencies.

adamwathan commented 3 years ago

Thank you!