tailwindlabs / tailwindcss-aspect-ratio

MIT License
972 stars 34 forks source link

Is it time to deprecate this plugin for good? #20

Closed benderillo closed 3 years ago

benderillo commented 3 years ago

What version of @tailwindcss/aspect-ratio are you using?

0.2.1

What version of Node.js are you using?

16.x.x

What browser are you using?

Chrome

What operating system are you using?

MacOS

Reproduction repository

github.com/tailwindlabs/tailwindcss-aspect-ratio

Describe your issue

The Readme.md says:

Once the aspect-ratio property is supported in modern browsers, we'll add official support to Tailwind CSS itself and deprecate this plugin.

Well, the aspect-ratio has made it to all the living browsers (I am not talking walking dead). Isn't it time then to deliver on the promise ;)?

adamwathan commented 3 years ago

Hey! Still too early, Safari 15 isn't actually released yet neither for macOS or iOS, and then even after that it'll be a while before usage of those versions is high enough to warrant abandoning Safari 14 support.

eboye commented 3 years ago

Living, breading Safari 15 here :D image

And can I use says we are in green! :D

https://caniuse.com/?search=aspect-ratio

I just hope that this plugin would use this in next version so I don't have to refactor my code :)

tlylt commented 3 years ago

Living, breading Safari 15 here :D image

And can I use says we are in green! :D

caniuse.com/?search=aspect-ratio

I just hope that this plugin would use this in next version so I don't have to refactor my code :)

aspect-ratio is still a WebKit experimental feature for many people who use Safari on their iPhone (at least around this time).

adamwathan commented 3 years ago

We've added native aspect-ratio support for Tailwind 3 🥳 but will continue to keep this plugin around and supported for people who have to support Safari 14 and below (which is going to be a lot of people for a while!)