search

tailwindlabs / tailwindcss-aspect-ratio

MIT License
972 stars 34 forks source link

deprecated - In favor of integrations in core Tailwind 3.0 #31

Closed Triloworld closed 2 years ago

Triloworld commented 2 years ago

What version of @tailwindcss/aspect-ratio are you using?

0.4.0

What version of Node.js are you using?

v14.17.2

What browser are you using?

Chrome

What operating system are you using?

Windows

Reproduction repository

Tailwind 3.0.0 now in core have this plugin! Check official docs

Describe your issue

By default this plugin is no longer needed for new version. Pleas block usage of it or write message and in console.log warm about incompatibility.

Doc: https://tailwindcss.com/docs/aspect-ratio

Right now Plugin remove default one options and replace with one provided in readme.md (not merge plugin and core options) This isn't needed as can be used in syntax [] for any variants, new options can be defined in tailwindcss.config.js and no need separate plugin.

kamilmedrala commented 2 years ago

The fact that the plugin disables default utilities should be mentioned in the documentation.

reinink commented 2 years ago

Hey! So this plugin is not deprecated, as it's still useful if you need to support Safari 14, which I suspect most people still do. For example, even on the new Tailwind CSS documentation website we're still using this plugin for all areas that we need aspect ratio support (other than on the new aspect-ratio utilities page, of course).

@kamilmedrala Yes, good call, it's on our TODO list 👍

reinink commented 2 years ago

@kamilmedrala Added: https://github.com/tailwindlabs/tailwindcss-aspect-ratio/blob/master/README.md#compatibility-with-default-aspect-ratio-utilities

kamilmedrala commented 2 years ago

Looks great!

Triloworld commented 2 years ago

About adding plugin in PlayCDN: https://github.com/tailwindlabs/tailwindcss.com/pull/1060

Why default settings is exclusive rather inclusive of variety of options? Adding plugin is a way to add more options. Just editing default setting won't break anything and only be aligned with expectation from newcomers. That's win - win for anybody and don't need documentation for that type. Just curious, maybe something working differently than expected?