search

tailwindlabs / tailwindcss-forms

A plugin that provides a basic reset for form styles that makes form elements easy to override with utilities.
https://tailwindcss-forms.vercel.app
MIT License
4.22k stars 223 forks source link

Make rings configurable #150

Closed TheDevMinerTV closed 10 months ago

TheDevMinerTV commented 1 year ago

Hey 👋

I've made the changes needed to make rings disableable (is that a word?) since it's been super annoying to just slap focus:ring-0 onto every <input> since I generally don't use rings in my applications. They're also super annoying to override, for example with checkboxes where it isn't possible to get rid of this behaviour at all (adding focus:outline-none focus:ring-0 to my checkbox doesn't seem to do anything except make the outline white instead of non-existant).

This is an optional flag that can be passed to the plugin initialize function. This makes sure that people updating their packages won't get a surprise when their rings stop existing.

This is related to https://github.com/tailwindlabs/tailwindcss/discussions/12143.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 10:30pm
adamwathan commented 10 months ago

Hey thanks for the PR! Generally we have tried to avoid configuration of this type for this version of the plugin and instead encourage people to make customizations using CSS:

https://github.com/tailwindlabs/tailwindcss-forms/issues/33#issuecomment-807883605

So going to say no to this one, but you should be able be able to make the changes you want by just layering some of your own base styles on top of what's provided by the plugin.