tailwindlabs / tailwindcss-intellisense

Intelligent Tailwind CSS tooling for Visual Studio Code
2.75k stars 183 forks source link

fix: bump `enhanced-resolve` for upstream fix #907

Closed llllvvuu closed 1 month ago

llllvvuu commented 4 months ago

EDIT: Sorry, I just noticed https://github.com/webpack/enhanced-resolve/pull/301 still hasn't been merged. In that case there would be a need to rebase enhanced-resolve-301 instead of this.

This pulls in https://github.com/webpack/enhanced-resolve/pull/353.

Otherwise, the following is broken (https://github.com/webpack/enhanced-resolve/issues/352):

module.exports = require('@acme/ui/tailwind.config.cjs')

where @acme/ui has:

"exports": {
  "./*.cjs": "./*.cjs",
},

and requires the following workaround

"exports": {
  "./tailwind.config.cjs": "./tailwind.config.cjs",
  "./*.cjs": "./*.cjs",
},

Bumping the package fixes this. The tailwindcss-language-server code has a comment referencing https://github.com/webpack/enhanced-resolve/issues/282, but that's been fixed upstream so I'm not sure if it's still a blocker for this.

llllvvuu commented 4 months ago

Sorry, I just noticed https://github.com/webpack/enhanced-resolve/pull/301 still hasn't been merged. In that case there would be a need to rebase enhanced-resolve-301 instead of this @bradlc .

thecrypticace commented 4 months ago

Hey, thanks for this — I'll take a look soon!

thecrypticace commented 1 month ago

Closing in favor of #971 — looks like enhanced-resolve has merged the fix for the PnP issuer bug.