search

tailwindlabs / tailwindcss.com

The Tailwind CSS documentation website.
https://tailwindcss.com
3.25k stars 1.72k forks source link

Update reusing-styles.mdx #1858

Closed gabrieldrouin closed 1 month ago

gabrieldrouin commented 1 month ago

Replace usage of <div> tag with <h4> tag, following the provided example from above.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 5:07pm
adamwathan commented 1 month ago

Thanks for catching this inconsistency! Made a small tweak to actually go the other way and just standardize on div for these these, as in reality the way you'd properly use that element as a title is using aria-labelledby on some sort of aria region, not using an h4 (since there's no guarantee there's an h3 earlier in the same scope of content).

gabrieldrouin commented 1 month ago

Thank you for your feedback Adam!