search

tailwindlabs / tailwindui-issues

Bug fixes and feature request tracking for Tailwind UI.
233 stars 4 forks source link

future of ComponentPropsWithoutRef and React 19 #1595

Closed logemann closed 3 months ago

logemann commented 3 months ago

What component (if applicable) catalyst components

Describe the bug Its not really a bug but merely a hint / suggestion

Throughout the catalyst component library, we will have the typical usage of React.ComponentPropsWithoutRef. I wonder if this apporach is still viable with the advent of React 19.

AFAIK we can safely pass in a ref as prop from the outside now and this should also be possibe with the catalyst components shouldnt it?

reinink commented 3 months ago

Hey!

Yeah we definitely have our eyes on React 19, but given that it hasn't even officially been released yet Catalyst is going to remain a React 18 project for now.

That said, I just tried using Catalyst in a React 19 project and it appeared to work, so that's good news at least for anyone wanting to use Catalyst on the bleeding-edge. But fair warning, I hardly tested this extensively 😅

Also keep in mind that not all dependencies are React 19 compatible yet, so you'll need to use the --force flag when installing these dependencies together.

Once React 19 becomes the de facto React version we'll definitely revisit this — I for one would love to remove all the forwardRef calls in this project! 🙌

Hope that makes sense!

logemann commented 3 months ago

I am already using catalyst with React 19 with our brand new project. So yeah... everything good. Just wanted to give you a hint there... Sorry for the noise in the bug tracker ;-)

Update: of course there some browser console warnings from headlessui for instance like: app-index.js:34 Warning: Accessing element.ref was removed in React 19. ref is now a regular prop. It will be removed from the JSX Element type in a future release.

But anyway.. nothing that bugs me at this point ;-)