taimos / dvalin

Taimos microservices framework
Apache License 2.0
14 stars 6 forks source link

Modularization of i18n resource loader #64

Closed siglocpp closed 6 years ago

siglocpp commented 6 years ago

This commit modularizes i18n resource loader. This enables easier support for future implementations of other resource formats (e.g. YAML).

codecov-io commented 6 years ago

Codecov Report

Merging #64 into master will increase coverage by 0.15%. The diff coverage is 78.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
+ Coverage     23.57%   23.72%   +0.15%     
- Complexity      287      290       +3     
============================================
  Files           123      124       +1     
  Lines          3003     3009       +6     
  Branches        355      355              
============================================
+ Hits            708      714       +6     
  Misses         2237     2237              
  Partials         58       58
Impacted Files Coverage Δ Complexity Δ
...java/de/taimos/dvalin/i18n/xml/I18nXMLHandler.java 69.04% <69.04%> (ø) 5 <5> (?)
...rc/main/java/de/taimos/dvalin/i18n/I18nLoader.java 86.11% <86.11%> (ø) 16 <16> (?)
.../java/de/taimos/dvalin/i18n/xml/I18nXMLReader.java 91.66% <91.66%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05154a8...896938e. Read the comment docs.