search

taimos / dvalin

Taimos microservices framework
Apache License 2.0
14 stars 6 forks source link

fixes a bug in DaemonScanner preventing method discovery #72

Closed siglocpp closed 6 years ago

siglocpp commented 6 years ago

in some situations it was possible, that the DaemonScanner was not able to find annotated methods because the sequence of interfaces lead to a NoSuchMethodException and the annotation discovery was aborted too early.

hoegertn commented 6 years ago

It seems the file is broken. See diff...

codecov-io commented 6 years ago

Codecov Report

Merging #72 into master will increase coverage by 0.09%. The diff coverage is 63.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #72      +/-   ##
===========================================
+ Coverage     21.01%   21.1%   +0.09%     
- Complexity      318     320       +2     
===========================================
  Files           154     154              
  Lines          3883    3885       +2     
  Branches        433     433              
===========================================
+ Hits            816     820       +4     
  Misses         3006    3006              
+ Partials         61      59       -2
Impacted Files Coverage Δ Complexity Δ
...alin/interconnect/model/service/DaemonScanner.java 62.42% <63.19%> (+1.68%) 35 <35> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdb652c...32a4e6d. Read the comment docs.

siglocpp commented 6 years ago

That's exactly what I'm doing, since this is a recursive method, I need to catch the Exception where I put it ....