taintacular / currentwidget

Automatically exported from code.google.com/p/currentwidget
0 stars 0 forks source link

Does it work on Samsung Galaxy S #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by m.kef...@gmail.com on 7 Oct 2013 at 7:14

GoogleCodeExporter commented 9 years ago
I'm so sorry,when I type this title ,I pressed the enter for wrong.
exactly,I would ask dose it work on galaxy s 3(GT-I9300)
I installed it ,but I can't read the number of current.It always display as 
0mA.I didn't kown whether it need root or not.My device is not rooted
Thank you

Original comment by m.kef...@gmail.com on 7 Oct 2013 at 7:21

GoogleCodeExporter commented 9 years ago
As far as I've heard, Galaxy S3 doesn't report the mA value in the battery 
driver , so I can't support it.

Original comment by ran.ma...@gmail.com on 14 Oct 2013 at 1:11

GoogleCodeExporter commented 9 years ago
thank you

Original comment by m.kef...@gmail.com on 14 Oct 2013 at 4:06

GoogleCodeExporter commented 9 years ago
actually s3 reports the mA value too. Also all S series has this ability too. 
There is an app named "Galaxy Charging Current Lite" for this. (it is written 
by a xda-developers member, you can find it on Google play) But we have an 
issue; "maximum", "now" and "avg" tagged values are messed. "maximum" and "now" 
tags are opposite. "avg" tag is correct. i mean, "maximum" tag is always shows 
the valid charging value. i have tested this current value with the 
potentiometer. If you want, i can capture a video about it and can prove it. 

The correct file which shows the current value is : 

/sys/class/power_supply/battery/current_max

I have edited your "CurrentReaderFactory.java" file, and now your app is 
support all galaxy s3 models.

Also, if you want, you can support all galaxy s series with this way.

Please add this lines into your project to help all galaxy s3 owners who are 
wanna use your app. (s3 sold millions and lots of people had trouble with this 
currentMeter issue.)

/* Samsung Galaxy S3 BUILD_MODELS
         * 
         * 
         * Taken from Wikipedia S3 page. (http://en.wikipedia.org/wiki/Samsung_Galaxy_S_III)

        GT-I9300[T]   
        GT-I9305[N/T]
        SHV-E210K/L/S
        SGH-T999/L[v]
        SGH-I747[m]
        SGH-N064(SC-06D)    
        SGH-N035(SC-03E)
        SCH-J021(SCL21) 
        SCH-R530    
        SCH-I535
        SCH-S960L
        GT-I9308
        SCH-I939
        SCH-S968C

        */

        // Galaxy S3
        if (CurrentReaderFactory.BUILD_MODEL.contains("gt-i9300")
            || CurrentReaderFactory.BUILD_MODEL.contains("gt-i9300T")

            || CurrentReaderFactory.BUILD_MODEL.contains("gt-i9305")
            || CurrentReaderFactory.BUILD_MODEL.contains("gt-i9305N")
            || CurrentReaderFactory.BUILD_MODEL.contains("gt-i9305T")

            || CurrentReaderFactory.BUILD_MODEL.contains("shv-e210k")
            || CurrentReaderFactory.BUILD_MODEL.contains("shv-e210l")
            || CurrentReaderFactory.BUILD_MODEL.contains("shv-e210s")

            || CurrentReaderFactory.BUILD_MODEL.contains("sgh-t999")
            || CurrentReaderFactory.BUILD_MODEL.contains("sgh-t999l")
            || CurrentReaderFactory.BUILD_MODEL.contains("sgh-t999v")

            || CurrentReaderFactory.BUILD_MODEL.contains("sgh-i747")
            || CurrentReaderFactory.BUILD_MODEL.contains("sgh-i747m")

            || CurrentReaderFactory.BUILD_MODEL.contains("sgh-n064")
            || CurrentReaderFactory.BUILD_MODEL.contains("sc-06d")

            || CurrentReaderFactory.BUILD_MODEL.contains("sgh-n035")
            || CurrentReaderFactory.BUILD_MODEL.contains("sc-03e")

            || CurrentReaderFactory.BUILD_MODEL.contains("SCH-j021")
            || CurrentReaderFactory.BUILD_MODEL.contains("scl21")

            || CurrentReaderFactory.BUILD_MODEL.contains("sch-r530")

            || CurrentReaderFactory.BUILD_MODEL.contains("sch-i535")

            || CurrentReaderFactory.BUILD_MODEL.contains("sch-S960l")

            || CurrentReaderFactory.BUILD_MODEL.contains("gt-i9308")

            || CurrentReaderFactory.BUILD_MODEL.contains("sch-i939")

            || CurrentReaderFactory.BUILD_MODEL.contains("sch-s968c")

            )  {
            f = new File("/sys/class/power_supply/battery/current_max");
            if (f.exists()) {
                return OneLineReader.getValue(f, false);
            }
        }

Original comment by yusufyus...@gmail.com on 11 Mar 2014 at 4:40

GoogleCodeExporter commented 9 years ago
I remember that I checked a few S3 before and didn't see that file, but I'll 
add it to CurrentWidget anyway.
Thanks!

Original comment by ran.ma...@gmail.com on 11 Mar 2014 at 5:00

GoogleCodeExporter commented 9 years ago

Original comment by ran.ma...@gmail.com on 11 Mar 2014 at 5:00

GoogleCodeExporter commented 9 years ago
thanks a lot, i wish to advise your app to my friends, but it is hard to 
install it from my compiled apk. if you update your app on google play, we can 
install it from google play. now google play says, there are "compability" 
problems and don't let us to install it. you should change it too.

also, if you want to see more, please read here : 
http://forum.xda-developers.com/showthread.php?t=2076078

Original comment by yusufyus...@gmail.com on 11 Mar 2014 at 5:04

GoogleCodeExporter commented 9 years ago
Sure, once I update the change in the play store I will change the 
compatibility of the app.
Thanks.

Original comment by ran.ma...@gmail.com on 11 Mar 2014 at 5:14

GoogleCodeExporter commented 9 years ago

Original comment by ran.ma...@gmail.com on 22 Mar 2014 at 7:01

GoogleCodeExporter commented 9 years ago
This change is now in beta, let me know if you want to join the beta program 
and test it.
Thanks.

Original comment by ran.ma...@gmail.com on 5 Aug 2014 at 9:26

GoogleCodeExporter commented 9 years ago
Hi, I added this to the beta, you can get it by joining the beta G+ community 
here:
https://plus.google.com/communities/113238127822514953442

Original comment by ran.ma...@gmail.com on 6 Aug 2014 at 4:46