taion / use-named-routes

[No Maintenance Intended] Drop-in named route support for React Router
MIT License
105 stars 8 forks source link

createLocation ignores action parameter #17

Closed maspwr closed 8 years ago

maspwr commented 8 years ago

The createLocation function ignores the action parameter from createLocationFromRedirectInfo. Is this intentional? It seems to break the functionality of IndexRedirect since the new location is created as a POP instead of a REPLACE.

taion commented 8 years ago

Want to PR a fix? Looks like we just need to pass through the extra arguments to history.createLocation.

maspwr commented 8 years ago

Yeah, that's what I was thinking. PR incoming...