search

tair / toastdos-back

The back-end system for the GOAT community annotation tool
GNU General Public License v3.0
7 stars 0 forks source link

Curated Annotations should be attributed to the submitter, not the curator who reviewed them #347

Closed lreiser closed 5 years ago

lreiser commented 5 years ago

I noticed that the in the display of search results, the name associated with the curated submission is the curator, not the submitter.

After reviewing and accepting annotations submitted by Ian , I looked to see what displayed in the search and found that the attribution was to me, not Ian.

Need to verify that the submitter is associated in the results and GAF file when it is exported.

screenshot_1649

lreiser commented 5 years ago

will advance to critical if it turns out that the GAF format also has same error.

lreiser commented 5 years ago

After checking the GAF file on the correct server (http://3.16.181.171:4200/search) it appears that the GAF file is also incorrectly attributing the submission to me. The ORCiD associated with the highlighted entry is mine.

screenshot_1655

Also note there is some weirdness with the results of the search. If you just type in a letter (say s) there are a large number of seemingly incomplete data rows. Will look into this as separate issue.

JKingSE commented 5 years ago

I can confirm that Leonore curating my submitted annotation changed the database itself to mark her as the submitter. So this is either a problem with the front-end sending in the curator as the submitter and overwriting the original submitter, OR the backend takes in the information and overwrites it when it saves the new status. I'll look into the backend to see if the problem lies there

JKingSE commented 5 years ago

This bug is ready to be checked. Any previous annotations that had been changed are going to stay changed, but new submissions from this point on should not see the submitter change when they are curated. This can be checked through search, export after the file has been made, or direct access to the database.

lreiser commented 5 years ago

tested w three annotations submitted by JK today JK orcid =0000-0001-9947-4545 seems to be fine. screenshot_1683