taiscremaschi / 42_Irc

2 stars 2 forks source link

Seg. Fault #49

Closed paulasbia closed 2 months ago

paulasbia commented 2 months ago

Context

When we create a client, join a group and leave the server, this group has some leaks

How to reproduce

  1. Start our server
  2. Create a nc client (you can use the HexChat too)
  3. Join the group #seg
  4. Part this group
  5. Quit
nc 0 8081
PASS 42irc
NICK paula
USER paula
JOIN #seg 
PART #seg   
QUIT :Leaving
  1. Now, create a new client
  2. Try join the group #seg
nc 0 8081
PASS 42irc
NICK tata
USER tatazinha
JOIN #seg 

The segmentation will be like this:


=================================================================
==646781==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d000000070 at pc 0x7ed0c663a397 bp 0x7ffd0fa47b90 sp 0x7ffd0fa47338
READ of size 5 at 0x60d000000070 thread T0
    #0 0x7ed0c663a396 in __interceptor_memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827
    #1 0x7ed0c634f123 in void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>(char*, char*, std::forward_iterator_tag) (/lib/x86_64-linux-gnu/libstdc++.so.6+0x14f123)
    #2 0x6475c9937781 in Client::getNickname[abi:cxx11]() const srcs/Client.cpp:38
    #3 0x6475c993d765 in Channel::searchOperator(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) srcs/Channel.cpp:104
    #4 0x6475c994426d in ServerManager::handleJoinCommand(Client&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) srcs/ServerManager.cpp:112
    #5 0x6475c994d108 in ServerManager::findCmd(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, Client&, IrcMessages&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) srcs/ServerManager.cpp:461
    #6 0x6475c994dc3b in ServerManager::handleIrcCmds(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) srcs/ServerManager.cpp:496
    #7 0x6475c9934214 in Server::runServer() srcs/Server.cpp:111
    #8 0x6475c9934c4c in Server::inicializeServer() srcs/Server.cpp:166
    #9 0x6475c9932f2c in main srcs/main.cpp:28
    #10 0x7ed0c5e29d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #11 0x7ed0c5e29e3f in __libc_start_main_impl ../csu/libc-start.c:392
    #12 0x6475c9932b24 in _start (/home/paula/42lisboa/42_Irc/ircserv+0x5b24)

0x60d000000070 is located 48 bytes inside of 144-byte region [0x60d000000040,0x60d0000000d0)
freed by thread T0 here:
    #0 0x7ed0c66b6d07 in operator delete(void*) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:160
    #1 0x6475c9942b5c in ServerManager::removeClientByNick(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) srcs/ServerManager.cpp:24
    #2 0x6475c994772a in ServerManager::handleQuit(Client&, IrcMessages&) srcs/ServerManager.cpp:207
    #3 0x6475c994d323 in ServerManager::findCmd(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&, Client&, IrcMessages&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) srcs/ServerManager.cpp:470
    #4 0x6475c994dc3b in ServerManager::handleIrcCmds(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) srcs/ServerManager.cpp:496
    #5 0x6475c9934214 in Server::runServer() srcs/Server.cpp:111
    #6 0x6475c9934c4c in Server::inicializeServer() srcs/Server.cpp:166
    #7 0x6475c9932f2c in main srcs/main.cpp:28
    #8 0x7ed0c5e29d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

previously allocated by thread T0 here:
    #0 0x7ed0c66b61e7 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99
    #1 0x6475c9933cf4 in Server::newClientConnection() srcs/Server.cpp:87
    #2 0x6475c9934033 in Server::runServer() srcs/Server.cpp:104
    #3 0x6475c9934c4c in Server::inicializeServer() srcs/Server.cpp:166
    #4 0x6475c9932f2c in main srcs/main.cpp:28
    #5 0x7ed0c5e29d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

SUMMARY: AddressSanitizer: heap-use-after-free ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827 in __interceptor_memcpy
Shadow bytes around the buggy address:
  0x0c1a7fff7fb0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c1a7fff7fc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c1a7fff7fd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c1a7fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c1a7fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c1a7fff8000: fa fa fa fa fa fa fa fa fd fd fd fd fd fd[fd]fd
  0x0c1a7fff8010: fd fd fd fd fd fd fd fd fd fd fa fa fa fa fa fa
  0x0c1a7fff8020: fa fa 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c1a7fff8030: 00 00 00 00 fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c1a7fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c1a7fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==646781==ABORTING

image

taiscremaschi commented 2 months ago

CHEEEEEECK GATA!!!! hehehehe facil.