taishi-i / nagisa

A Japanese tokenizer based on recurrent neural networks
https://huggingface.co/spaces/taishi-i/nagisa-demo
MIT License
379 stars 22 forks source link

Wheel request for Python 3.8 #24

Closed himkt closed 2 years ago

himkt commented 4 years ago

Hello, thank you for maintaining the awesome toolkit!

I think we cannot install nagisa by pip install nagisa on Python>=3.8. This is because:

The full output of pip install nagisa on Python3.8: https://gist.github.com/himkt/1bc75b83f1735535c4df0b952f352bf6

taishi-i commented 4 years ago

Hello @himkt. Thank you for your contact. Thank you again for incorporating this tool into konoha.

I guess the fundamental problem is that the DyNet does not provide wheels for Python 3.8 in PyPI. Even if nagisa provides wheels for 3.8, we can't install it unless DyNet provides wheels for 3.8.

To resolve this issue, we need to ask the developers of DyNet to provide us with wheels for 3.8+. So, I'll ask the developers if they are planning to provide wheels for 3.8+.

taishi-i commented 4 years ago

I created https://github.com/clab/dynet/issues/1618#issue-695104515 in DyNet repository. Thank you for the opportunity to do this. Let's wait for their reply.

himkt commented 4 years ago

Even if nagisa provides wheels for 3.8, we can't install it unless DyNet provides wheels for 3.8.

I'm really sorry that I didn't understand the situation correctly. It makes sense.

I created clab/dynet#1618 (comment) in DyNet repository.

Thank you very much! If nagisa also works on the latest version of Python, it remains a nice choice for starting NLP, I think. I'll also be checking the issue. Thanks again for the very quick response.

taishi-i commented 3 years ago

Hi @himkt ! I created DyNet38 to provide DyNet's wheels for Python 3.8+. I have released nagisa's wheels for Python 3.8+, so we can already use nagisa in Python 3.8+. https://github.com/taishi-i/nagisa/blob/30f0e3389eae07b060ab8b2321bf477168ebcc2d/setup.py#L70

However, it is only for the Linux environment. Let me know if you want to use it on maxOS or windows. It may take some time, but I will prepare the wheels.

OS\Python version 2.7 3.5 3.6 3.7 3.8 3.9
Linux
macOS × ×
Windows × ×
himkt commented 3 years ago

Hi @taishi-i, thank you so much for your effort!! I usually use nagisa on Ubuntu so it really helps me. 👍

dj-sorry commented 3 years ago

I'm using nagisa on Mac to build a classifier - is there a timeline on when will I be able to use nagisa with 3.8?

taishi-i commented 3 years ago

Hi @dj-sorry. Thank you for using naigsa. Sorry, I don't have a specific timeline at this point. The DyNet developer team is planning to support for building Python 3.8 wheels https://github.com/clab/dynet/issues/1618#issuecomment-704185703. After that, I will provide Python 3.8 wheels for macOS. Please wait for a few weeks. Thank you.

himkt commented 3 years ago

Thank you @taishi-i for letting us know about the release plan of dynet. I'm not sure whether I should close this issue, as this is dynet side problem (but someone using nagisa may encounter the problem ad this issue could be helpful for understanding the current situation).

Do you think we can close this issue or should leave it as is until a dynet support is available?

k-tsutsu commented 3 years ago

Thank you @taishi-i for creating a good product 'nagisa'. And thank you @himkt for your good comments and some advices I think that many people want to know about supporting status for Python 3.8, and I want to know that too. Original Dynet committer has said he had supported it for Python 3.8.

himkt commented 3 years ago

Original Dynet committer has said he had supported it for Python 3.8.

Thank you for letting us know. 😄 In my environment (Python3.8.5), I could build dynet v2.1.2!