taisph / laravel-opentracing

OpenTracing for Laravel
Apache License 2.0
12 stars 11 forks source link

"jonahgeorge/jaeger-client-php" has removed the "dev-feature/php56" branch. #9

Open thinkspill opened 5 years ago

thinkspill commented 5 years ago
$ composer require taisph/laravel-opentracing
[...]
 Problem 1
    - taisph/laravel-opentracing 1.0.0-rc.2 requires jonahgeorge/jaeger-client-php dev-feature/php56 -> no matching package found.
    - taisph/laravel-opentracing 1.0.0-rc.1 requires jonahgeorge/jaeger-client-php dev-feature/php56 -> no matching package found.
    - Installation request for taisph/laravel-opentracing ^1.0@RC -> satisfiable by taisph/laravel-opentracing[1.0.0-rc.1, 1.0.0-rc.2].

It looks like the repo "jonahgeorge/jaeger-client-php" has removed the "dev-feature/php56" branch.

taisph commented 5 years ago

This is due to a workaround by me to retain PHP 5.6 support. There are a few projects still using this and I want to give them time to port the code.

The branch only exists in my forked version of the "jonahgeorge/jaeger-client-php" package. As noted in the README, you need to add the lines below to your composer.json file in the "repositories" section.

{
    "type": "vcs",
    "url": "https://github.com/taisph/jaeger-client-php"
}
thinkspill commented 5 years ago

Ah, I see. I was confused by this sentence:

If you need that in your application, add the config below to your composer.json file in the repositories section.

Given that I do not need php 5.6 support in my app, I thought this would not apply to me. But it sounds like adding this repo is required as that source repo is now gone.

Thanks for the clarification.