search

taitems / jQuery.Gantt

jQuery Gantt Chart
http://taitems.github.io/jQuery.Gantt/
MIT License
952 stars 304 forks source link

Added package.json to allow install from npm #251

Closed Lukas238 closed 3 years ago

Lukas238 commented 3 years ago

Hi!,

I want to use this package in a project.

To be able to install and package all it dependencies using node.js, I need to be able to install this package using npm. To do so, the package need to include a package.json file. This PR adds this file.

I included the correct author, license, and GitHub URL. I also bumped the version to 1.1.1, as the version 1.1.0 as this PR will also include all the changes merged after the version 1.1.0.

Hope this can be merged.

Best regards! :)

taitems commented 3 years ago

Hi @Lukas238 i've been weighing up this one for a while as to whether it made sense to do (given how old this project is). Glad to hear there's a need for this. I'll hopefully have a look at this tonight/tomorrow AEST.

taitems commented 3 years ago

I've had to rename to, and publish under, @taitems/jquery-gantt due to package name clashes on npm.

usmonster commented 3 years ago

Thanks, @taitems! I'd "been meaning to do it" as part of the next release (#162), but I admit that has been gathering quite a bit of dust. 😬

FYI, this could probably also satisfy #248 if you push the new tag that must've been created as part of the NPM release?

Also, regarding the package name clash—I see someone already has jquery.gantt, but can you just grab plain jquery-gantt (not taken, it seems), or does NPM not allow registering that either?

Finally, please don't forget to add the jquery-plugin and ecosystem:jquery keywords to the package, and feel free to add me as a collaborator there as well, if possible. Thanks again! 😄

taitems commented 3 years ago

@usmonster Excellent advice, will do.

Re: jquery-gantt, I attempted that too but npm throws a "too similar" warning which I think is fair.