search

taiwanese-work-in / foreign-country

出國工作共同知識庫 / 站務 / taiwanese-work.in 網站
http://taiwanese-work.in
65 stars 1 forks source link

Add favicon.ico #19

Closed yorkxin closed 8 years ago

yorkxin commented 8 years ago

solves https://github.com/taiwanese-work-in/foreign-country/issues/14

Why is this change necessary?

ascendbruce commented 8 years ago

Do you consider also declaring in the web page footer?

yorkxin commented 8 years ago

I think declaring in the repository is good enough? Since we have a link to the source code repository.

ascendbruce commented 8 years ago

I prefer not to take risk on the legal side (sorry was busy last few days)

yorkxin commented 8 years ago

Alright. I will add it to the footer.

yorkxin commented 8 years ago

done!

ascendbruce commented 8 years ago

Thanks! @chitsaou