Closed vsimko closed 7 years ago
Merging #103 into master will increase coverage by
0.41%
. The diff coverage is96.55%
.
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 91.33% 91.75% +0.41%
==========================================
Files 7 8 +1
Lines 612 643 +31
==========================================
+ Hits 559 590 +31
Misses 53 53
Impacted Files | Coverage Δ | |
---|---|---|
R/corrMatOrder.R | 100% <ø> (ø) |
:arrow_up: |
R/cor-mtest.R | 100% <100%> (ø) |
|
R/corrplot.R | 89.9% <100%> (+0.18%) |
:arrow_up: |
R/corrplot.mixed.R | 91.66% <71.42%> (+0.75%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c6d00c...5906f2a. Read the comment docs.
Three cor.mtest()
in Rmd file. Just need one.
I just refactored the cor.mtest()
function that was used on multiple places (see also issue #82).
The function now returns a list containing three elements: p
, lowCI
and uppCI
which I think is better than just a tuple.
I see. The problem is that we linked to some external figure on the web which is not accessible anymore. I'll fix it.
Now the build finally passes!
The figure in README.md
is not generated by
corrplot(M, order = "hclust", addrect = 2)
fixed through web interface
I removed the new
isMixed
parameter which also fixes issue #102 and used themar
parameter instead. This way, the issue #102 is fixed and we don't have to extend the already huge API ofcorrplot
.Additionally in this pull request:
t.pos="n"
.corrplot
functional hopefully in future.