search

tajmone / ST4-Asciidoctor

AsciiDoc Package for SublimeText 4
https://tajmone.github.io/ST4-Asciidoctor
MIT License
11 stars 6 forks source link

Several syntax-highlighting enhancements #12

Closed polyglot-jones closed 3 years ago

polyglot-jones commented 3 years ago

In a nutshell, I took what Aiden Reilly started with redefining the AsciiDoc syntax into the new .sublime-syntax format and finished all of the commented out "to-do"s.

tajmone commented 3 years ago

I'll need some time to review all your PRs in detail, hopefully I'll manage later on in the day, once I've finished dealing with an ongoing work.

I'm quite reluctant to accept PRs directly in master and I'd prefer them to go in the dev branch, so that before they end up being used in production by users of this package we have a chance to test everything well and polish documentation, etc. I also tend to make my commits on dev first, until I'm happy that the new features are ready to be finalized into master.

Also, I see that all PRs (#12, #13 and #14) are failing the Travis CI build, which means that there are issues with code styles formatting. I haven't yet had the chance to look into the details, but I can see that the Travis build log for this PR is reporting formatting issues with the following files:

~~~ ERROR! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The following files didn't pass the validation test:

Color_Schemes/AsciiDoc_Base16.sublime-color-scheme
Color_Schemes/AsciiDoc_DarkViolet.sublime-color-scheme
Color_Schemes/AsciiDoc_Equilibrium_Gray_Light.sublime-color-scheme
Syntaxes/Asciidoctor.sublime-syntax

Run ECLint locally for detailed information about the problems.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/// Aborting All Tests ///
polyglot-jones commented 3 years ago

I'll just close this outright and re-submit a new PR against dev.