tajmone / ST4-Asciidoctor

AsciiDoc Package for SublimeText 4
https://tajmone.github.io/ST4-Asciidoctor
MIT License
11 stars 6 forks source link

Syntax Baseline #32

Closed polyglot-jones closed 3 years ago

polyglot-jones commented 3 years ago

Asciidoctor.sublime-syntax -- Comments Only:

Added Examples/Syntax_Demo.adoc -- All is okay until we get to the table at the end with the known issue of carets that get misinterpreted.

tajmone commented 3 years ago

I'm not convinced about removing some of these comments. While I was trying to compare different ST3 syntax ports of the original, from various forks, I've noticed that some authors chose alternative approaches and I wanted to store them as comments after a three-way merge. In fact, some of the commented code seems to contain smarter RgExs definitions than the one currently being uses.

The main reason why I kept them commented was that they often used different scopes naming, which would mean that I'd have to tweak the ad hoc colour schemes if I were to use that code.

I know that those long comments are annoying, but at least they allow me to spare time (as opposed to do live diffing between the different syntax each time). I have serious problems finding spare time to work on this syntax (very spread thin) and these comments are like TODOs that I haven't managed to look into yet (either integrate or discard). Deleting them would basically trash off my whole scheduled work on this syntax.

Just give me a few days to review this, I want go through the whole syntax again make sure I really want to get rid of those comments, or at least have time to annotate them elsewhere before deleting them.

tajmone commented 3 years ago

I just merged as it was. These comments and notes are so old that I can't even recall why I made most of them, so they are basically useless anyway.

We should probably concentrate on fixing the broken elements on our own, end of story.