search

tajmone / pandoc-goodies

A tresure-box of resources for pandoc, pp and Texts word processor.
MIT License
211 stars 41 forks source link

Floating Header Link in GitHub #11

Open MyriaCore opened 3 years ago

MyriaCore commented 3 years ago

Having a little link icon next to headers appear on hover would be pretty cool!

tajmone commented 3 years ago

Having a little link icon next to headers appear on hover would be pretty cool!

Unfortunately that feature became broken in the original template which I've adapted, although it was present in earlier versions of the template, and wasn't fixed for quite a long time. I haven't checked if it was fixed, but I'll give it a look when I get time.

MyriaCore commented 3 years ago

Any updates?

tajmone commented 3 years ago

I can confirm that the upstream GitHub template (replicated by @sindresorhus) has been updated, and now header links are working, as can be seen in the online demo:

https://sindresorhus.com/github-markdown-css/#h3

In order to update the local template I'll probably have to rebuild it from scratch, since the current version refers to an old GitHub template that was superseded by a new design.

I'm currently short of spare time due to a project with a very tight ETA, which is lagging behind. But I should be able to find a free day to dedicate to the template update somewhere in December, after the ETA is over.

In case I do forget, please feel free to buzz me and remind me about it! This template update is indeed required.

MyriaCore commented 3 years ago

Awesome! December is a bit away, though. Is the task just related to updating the version of the Github CSS? That should be simple, no? If I have any free time soon I could try to PR.

tajmone commented 3 years ago

Is the task just related to updating the version of the Github CSS?

Probably not, there might also be some changes to the HTML. GitHub has updated its styles at least twice since the original template was converted, so classes name might have changed too, which would also affect some PP macros related to the template, and the sample and test files (hence the suggestion that it's best to just rebuild the whole template, and its Sass/CSS).

Of course, a PR is most welcome.