Missing Accessibility Report button with @ladle/react v3.1.0 and up

tajo / ladle

🥄 Develop, test and document your React story components faster.

https://www.ladle.dev

MIT License

2.52k stars 86 forks source link

Missing Accessibility Report button with @ladle/react v3.1.0 and up #527

Closed esbeto closed 9 months ago

esbeto commented 9 months ago

Describe the bug

For some reason I lost the accessibility report and button when upgrading ladle, I tried different versions and the last one that works for me is 3.0.0

Reproduction

I was able to reproduce with Stackblitz. Just change the dependency to:

    "@ladle/react": "3.0.0",

to see the accessibility report button.

Environment

OS: MacOS Ventura 13.6
Browser: Firefox 118 Chrome 118
(I wasn't aware both browsers are now in matching version numbers 😅)

tajo commented 9 months ago

It's just disabled by default now. You can easily enable it again: https://ladle.dev/docs/a11y

axe-core is a pretty big dependency so we don't want to bundle it with Ladle unless it's actively used.

esbeto commented 8 months ago

Thanks! I suggest to include changes in defaults in the release notes next time.