tajo / react-movable

🔀 Drag and drop for your React lists and tables. Accessible. Tiny.
https://react-movable.pages.dev
MIT License
1.55k stars 51 forks source link

Contributing: cannot `yarn install` on arm mac #104

Closed IanVS closed 3 months ago

IanVS commented 4 months ago

I tried to contribute a feature, and when running yarn install I get the following error:

/Users/ianvs/code/ianvs/react-movable/node_modules/puppeteer: Command failed.
Exit code: 1
Command: node install.js
Arguments:
Directory: /Users/ianvs/code/ianvs/react-movable/node_modules/puppeteer
Output:
The chromium binary is not available for arm64:
If you are on Ubuntu, you can install with:

 apt-get install chromium-browser

/Users/ianvs/code/ianvs/react-movable/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:112
            throw new Error();
            ^

Error
    at /Users/ianvs/code/ianvs/react-movable/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserFetcher.js:112:19
    at FSReqCallback.oncomplete (node:fs:208:21)
IanVS commented 4 months ago

I tried updating puppeteer, which worked, but now I'm getting this error when I try to run the tests:

> ladle serve --output stream --open none

error: unknown option '--output'
tajo commented 3 months ago

Yea, I need to update the tooling in this repo (as I just did for https://github.com/tajo/react-range) and will go through these PRs. Thanks!

IanVS commented 3 months ago

@tajo I did some updates and was able to get tests passing in 8759779 (#106)