fix: touch scroll on elements with handle

tajo / react-movable

🔀 Drag and drop for your React lists and tables. Accessible. Tiny.

https://react-movable.pages.dev

MIT License

1.53k stars 51 forks source link

fix: touch scroll on elements with handle #46

Closed arturbani closed 4 years ago

arturbani commented 4 years ago

This PR tries to solve #30 and #13 issues. Basically I've removed touchAction: none on baseStyle and applied only when a touch element triggers onMouseOrTouchStart!

This enables elements with data-movable-handle to scroll when touching other areas.

Same as #39

IcebergRage commented 4 years ago

Thanks a lot, it works ! Need to be merged :)

tajo commented 4 years ago

This breaks every single example?

https://deploy-preview-46--react-movable.netlify.app/

arturbani commented 4 years ago

Woops, sorry @tajo . It was missing a verification step. Fixed and added a storybook example of handle + scroll.