react-dom is not listed in peerDependencies

tajo / react-portal

🎯 React component for transportation of modals, lightboxes, loading bars... to document.body or else.

MIT License

2.14k stars 169 forks source link

react-dom is not listed in peerDependencies #228

Open kirill-konshin opened 4 years ago

kirill-konshin commented 4 years ago

react-dom is not listed in peerDependencies which causes Yarn 2 in plug'n'play mode to fail

dasdachs commented 3 years ago

@kirill-konshin Any solution for this?

kirill-konshin commented 3 years ago

@dasdachs add this to .yarnrc.yml:

packageExtensions:
  react-portal@*:
    peerDependencies:
      react-dom: "*"

@tajo is this project alive? Yarn 2 has been released long ago, please fix properly.

dasdachs commented 3 years ago

@kirill-konshin Thanks, that did the trick. I did a PR regarding this, but it fails due to an conflicting peer dependency. Will try to solve this today.