search

tajo / react-titled

📃 Set document.title with ease. Nested. Flexible.
MIT License
47 stars 5 forks source link

Allow string title #9

Closed vezaynk closed 1 year ago

vezaynk commented 2 years ago

As noted in #5

vezaynk commented 2 years ago

Will do! I've been really busy, but I will get around to it.

vezaynk commented 1 year ago

@IanVS I added tests and added in a small refactor to decouple react-title from document.title (still leaving it as the default).

Let me know what you think.

IanVS commented 1 year ago

Thanks, it seems like this PR is now doing a few different things. Can you explain why you decoupled from setting the title? And maybe pull that to a separate PR so we can review / discuss it separately?

vezaynk commented 1 year ago

Okay I'll roll back my changes and split them into a few PRs

IanVS commented 1 year ago

Thanks! That will make them easier to review/discuss/merge.

vezaynk commented 1 year ago

@IanVS ready for reviewing btw