tajtiattila / metadata

Metadata package for go
MIT License
19 stars 4 forks source link

png + xmp? #3

Open s3rj1k opened 6 years ago

s3rj1k commented 6 years ago

add png support with xmp?

tajtiattila commented 6 years ago

That would be easy to implement, but I use this package mainly on my photos and videos, I don't have actual PNG files to work with.

Are you interested in implementing this, or do you have PNG files for testing?

s3rj1k commented 6 years ago

Hi @tajtiattila, thanks for quick response.

I am interested in using your package to add custom XMP metadata to photo archive, they will be in PNG and JPEG format.

Will be great if you could add support for png add add simple example on how to use this.

I would gladly test. thanks.

tajtiattila commented 6 years ago

Writing new metadata in MP4 or png would be easy, but writing XMP isn't implemented yet. This would require an XML package that can encode data it has decoded with correct namespace prefixes. This is a known problem with the current encoding/xml package, have a look at the many issues in the go project: https://github.com/golang/go/issues/13400

s3rj1k commented 6 years ago

@tajtiattila there is https://github.com/trimmer-io/go-xmp that could help with marshalling XMP

tajtiattila commented 6 years ago

Thank you, this might work. However, the package has to be cleaned up first based on a container and metadata registry before adding new container types.