search

taka-no-me / android-cmake

CMake toolchain file and other scripts for the Android NDK
1.22k stars 437 forks source link

Change 'ANDROID_ABI' default value to "armeabi-v7a with NEON" #21

Open apavlenko opened 10 years ago

apavlenko commented 10 years ago

Andrey, I would recommend you change the default ANDROID_ABI value to "armeabi-v7a with NEON" instead of "armeabi-v7a" since the 1st one is much more popular in real world.

andrew-aladev commented 10 years ago

+1

taka-no-me commented 9 years ago

Will change as soon as Google enables Neon by default in NDK build scripts.

ayberkozgur commented 9 years ago

+1

M1cha commented 9 years ago

Also I'd change the default SDK to 22 since it really just is the compiler and not the target api version. AndroidStudio uses it as default too.

rpavlik commented 9 years ago

Is it really just the compiler? It uses a different set of headers, and also (for instance) turns on PIE/PIC for 16 and up, etc. The changed headers in 21 or 22 broke an app that built earlier - Google removed a function from the headers that was there before, so had to make source changes.

M1cha commented 9 years ago

@rpavlik yea, after some Testing I know that you're right. Also I there's a huge bug: #58 When u use sth higher than android-8 for ARM (static) you either get tons of compilation errors or you get a dynamic binary even with "-static"