takac / vim-hardtime

Plugin to help you stop repeating the basic movement keys
MIT License
828 stars 30 forks source link

Request #24

Closed ghost closed 10 years ago

ghost commented 10 years ago

First of all, thanks for doing the way I imagined the hardmode should be (:

I did some refactoring in variables, just organizing the code. HardOn and HardOff is confusing, let the toggle do all the things, unifying. The way a changed the messages solves the request 23.

I think that if you want some plugin, it must be loaded automatically and that's the way most of the plugins work. Also, the messages tell the hardmode is enabled by default.

I added insert keys because sometimes I end up pressing the arrows keys for the habit of others applications - its a shame not every application is vim-like ): And its nice for who is learning hjkl, or just wanna put another prohibited key in insert mode.

Thanks!

takac commented 10 years ago

Thanks for the work, the clean up looks good. However you change the default back to what they were originally otherwise this change is going to break lots of people's config when they update. Could you also add back the 2 on/off commands. Thanks for your help :)

ghost commented 10 years ago

Ok, I'll remake the commits.

I agree this will break people's config, but for curiosity, this makes sense to you? Plugin off by default (and why you changed it?) and the two maps on/off which does the same as one map toggle (in my vision). Thanks for the reply.

takac commented 10 years ago

The reason I have it off by default is because it is a very annoying plugin :) It allows you to help modify your Vim behaviour but for day to day use it can be very invasive. I normally have it off and enable it to practice my Vim more. I'm sure other people use it in completely different ways but I want to keep the defaults.

As for the on off commands, they provide an unambiguous command which you can run just to make sure everything is the way you want it. The amounts times I have tried to disable a plugin but instead turned it on using the 'toggle' has changed the way I write my plugins.

ghost commented 10 years ago

Fixed. This toggle ~problem~ is really annoying for sure :p Thanks

takac commented 10 years ago

Looks good to me, thanks for the work!