takagi / cl-cuda

Cl-cuda is a library to use NVIDIA CUDA in Common Lisp programs.
MIT License
280 stars 24 forks source link

Make it build on ASDF 3.3 #88

Closed fare closed 7 years ago

fare commented 7 years ago

Call mark-operation-done when skipping a grovel-file.

Stop calling clear-system in perform.

Cleanup the .asd files to modern recommended style.

guicho271828 commented 7 years ago

@fare , Why don't you provide a transient version that just emits style-warning to the unrecommended style?

fare commented 7 years ago

I'm considering it. It wasn't a priority, and it's sometimes hard to detect in a nice way, but I'm coming to the realization that yes it's a good idea.

However, the clear-system thing was always a bug, and this bug will be glaring when ASDF 3.3 is released, which I was hoping would happen soon enough that I don't really have time for this transition. On the other hand, if it keeps being pushed back I may indeed implement such a style checker in 3.2.2.

Thanks for the suggestion!

takagi commented 7 years ago

Thanks!