search

takahirom / roborazzi

Make JVM Android integration test visible 🤖📸
https://takahirom.github.io/roborazzi/
Apache License 2.0
706 stars 32 forks source link

add flag in :roborazzi-core module #280

Closed sanao1006 closed 6 months ago

sanao1006 commented 6 months ago

why

Because of missing android.useAndroidX=true flag in :roborazzi-core module, build errors were occurring.

Fixes #278

sanao1006 commented 6 months ago

@takahirom Currently there are no build errors in your environment. However, adding the flag caused the error, so maybe this PR should be closed.

If I want to contribute something to Roborazzi, no problem to add the flag in my local environment.

What do you think?

takahirom commented 6 months ago

@sanao1006 We are using a symbolic link to ../gradle.properties in include-build/gradle.properties because we can share the gradle.properties with root modules. So you might have to change the root module :eyes:

sanao1006 commented 6 months ago

So you might have to change the root module

I see.

However, there is already a android.useAndroidX=true flag in root gradle.properties. https://github.com/takahirom/roborazzi/blob/08af633980359e153bf94045357a9a34b8ab415a/gradle.properties#L29

So I am not sure why the error is occurring in CI...

takahirom commented 6 months ago

@sanao1006 May I ask if you are using Windows PC? This is because the symbolic link may not work.

sanao1006 commented 6 months ago

@takahirom Yes, I use a Windows PC.

Hmmm... Then this issue may be a Windows-specific error.

takahirom commented 6 months ago

@sanao1006 As a workaround, I think you can copy and paste /gradle.properties to include-build/gradle.properties to build Roborazzi. Well, there are pros and cons of introducing the change so let me close for now.