takahirom / roborazzi

Make JVM Android integration test visible 🤖📸
https://takahirom.github.io/roborazzi/
Apache License 2.0
654 stars 25 forks source link

Hide action bar to avoid shadow creeping into images captured using captureRoboImage #283

Closed lukas-mercari closed 3 months ago

lukas-mercari commented 3 months ago

I tried out shadow rendering as outlined in #273 and noticed that there's a shadow from the top when using captureRoboImage with a composable parameter. This is visible in the diff for manual_compose in #273. It seems that it's caused by the action bar of RoborazziTransparentActivity rendering right above the composable and thus "leaking" a shadow into the screenshot.

I tested the change by applying it on top of #273.

takahirom commented 3 months ago

I didn't notice this. Looks great!

takahirom commented 3 months ago

@lukas-mercari Thanks for your contribution!