takahirom / roborazzi

Make JVM Android integration test visible 🤖📸
https://takahirom.github.io/roborazzi/
Apache License 2.0
649 stars 24 forks source link

Remove code that creates output dir if it doesn't exist #379

Open lukas-mercari opened 1 month ago

lukas-mercari commented 1 month ago

Since the output dir is optional now, we can cleanup the code that generates it.

lukas-mercari commented 1 month ago

unitTestWhenRunTwice is failing. I think the reason is that during the first run, the output dir gets created, so the second run has different inputs. Before this PR the output dir was created during the configuration phase, so the second run would be skipped since an empty output dir existed both for the first and second runs.

takahirom commented 1 month ago

I'm fine with merging this, but we must at least pass the test. I think it's great that we can set up by removing the output directory in the integration test before the build runs. However, I'm not sure if it's difficult.