if Alice uses grunt data (or grunt release) to prepare a custom-build, moment-timezone with the latest tzdata from IANA's website
and Mallory intercepts the request to IANA's unencrypted ftp server, Mallory can serve data which might exploit further stages of the moment-timezone tzdata pipeline, or potentially produce a tainted version of moment-timezone (practicality of such attacks is not proved)
Patches
Problem has been patched in version 0.5.35, patch should be applicable with minor modifications to all affected versions. The patch includes changing the FTP endpoint with an HTTPS endpoint.
Workarounds
Specify the exact version of tzdata (like 2014d, full command being grunt data:2014d, then run the rest of the release tasks by hand), or just apply the patch before issuing the grunt command.
All versions of moment-timezone from 0.1.0 contain build tasks vulnerable to command injection.
if Alice uses tzdata pipeline to package moment-timezone on her own (for example via grunt data:2014d, where 2014d stands for the version of the tzdata to be used from IANA's website),
and Alice let's Mallory select the version (2014d in our example), then Mallory can execute arbitrary commands on the machine running the grunt task, with the same privilege as the grunt task
Am I affected?
Do you build custom versions of moment-timezone with grunt?
If no, you're not affected.
Do you allow a third party to specify which particular version you want build?
If yes, you're vulnerable to command injection -- third party may execute arbitrary commands on the system running grunt task with the same privileges as grunt task.
Description
Command Injection via grunt-zdownload.js and MITM on iana's ftp endpoint
The tasks/data-download.js script takes in a parameter from grunt and uses it to form a command line which is then executed:
6 module.exports = function (grunt) {
7 grunt.registerTask('data-download', '1. Download data from iana.org/time-zones.', function (version) {
8 version = version || 'latest';
10 var done = this.async(),
11 src = 'ftp://ftp.iana.org/tz/tzdata-latest.tar.gz',
12 curl = path.resolve('temp/curl', version, 'data.tar.gz'),
13 dest = path.resolve('temp/download', version);
...
24 exec('curl ' + src + ' -o ' + curl + ' && cd ' + dest + ' && gzip -dc ' + curl + ' | tar -xf -', function (err) {
Ordinarily, one one run this script using something like grunt data-download:2014d, in which case version would have the value 2014d. However, if an attacker were to provide additional content on the command line, they would be able to execute arbitrary code
The tasks/data-zdump.js script reads a list of files present in a temporary directory (created by previous tasks), and for each one, assembles and executes a command line without sanitization. As a result, an attacker able to influence the contents of that directory could gain code execution. This attack is exacerbated by timezone data being downloaded via cleartext FTP (described above), but beyond that, an attacker at iana.org able to modify the timezone files could disrupt any systems that build moment-timezone.
15 files = grunt.file.expand({ filter : 'isFile', cwd : 'temp/zic/' + version }, '**/*');
...
27 function next () {
...
33 var file = files.pop(),
34 src = path.join(zicBase, file),
35 dest = path.join(zdumpBase, file);
36 exec('zdump -v ' + src, { maxBuffer: 20*1024*1024 }, function (err, stdout) {
In this case, an attacker able to add a file to temp/zic/2014d (for example) with a filename like Z; curl www.example.com would influence the called to exec on line 36 and run arbitrary code. There are a few minor challenges in exploiting this, since the string needs to be a valid filename.
Command Injection via data-zic.js
Similar to the vulnerability in /tasks/data-download.js, the /tasks/data-zic.js script takes a version from the command line and uses it as part of a command line, executed without sanitization.
10 var done = this.async(),
11 dest = path.resolve('temp/zic', version),
...
22 var file = files.shift(),
23 src = path.resolve('temp/download', version, file);
24
25 exec('zic -d ' + dest + ' ' + src, function (err) {
As a result, an attacker able to influence that string can run arbitrary commands. Of course, it requires an attacker able to influence the command passed to grunt, so may be unlikely in practice.
root@e94ba0490b65:/usr/src/app/moment-timezone# grunt 'data-zic:2014d; echo hi > /tmp/evil; echo '
Running "data-zic:2014d; echo hi > /tmp/evil; echo " (data-zic) task
exec: zid -d /usr/src/app/moment-timezone/temp/zic/2014d; echo hi > /tmp/evil; echo /usr/src/app/moment-timezone/temp/download/2014d; echo hi > /tmp/evil; echo /africa
...
root@e94ba0490b65:/usr/src/app/moment-timezone# cat /tmp/evil
hi
Patches
The supplied patch on top of 0.5.34 is applicable with minor tweaks to all affected versions. It switches exec to execFile so arbitrary bash fragments won't be executed any more.
moment/moment-timezone (moment-timezone)
### [`v0.5.35`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0535-2022-08-23)
[Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.34...0.5.35)
- Fix command injection in data pipeline https://github.com/moment/moment-timezone/security/advisories/GHSA-56x4-j7p9-fcf9
- Fix cleartext transmission of sensitive information https://github.com/moment/moment-timezone/security/advisories/GHSA-v78c-4p63-2j6c
Thanks to the OpenSSF Alpha-Omega project for reporting these!
### [`v0.5.34`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0534-2021-11-10)
[Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.33...0.5.34)
- Updated data to IANA TZDB `2021e`
### [`v0.5.33`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0533-2021-02-06)
[Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.32...0.5.33)
- Updated data to IANA TZDB `2021a`
### [`v0.5.32`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0532-2020-11-14)
[Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.31...0.5.32)
- Updated data to IANA TZDB `2020d`
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
[ ] If you want to rebase/retry this PR, check this box
This PR contains the following updates:
0.5.31->0.5.35GitHub Vulnerability Alerts
GHSA-v78c-4p63-2j6c
Impact
grunt data(orgrunt release) to prepare a custom-build, moment-timezone with the latest tzdata from IANA's websitePatches
Problem has been patched in version 0.5.35, patch should be applicable with minor modifications to all affected versions. The patch includes changing the FTP endpoint with an HTTPS endpoint.
Workarounds
Specify the exact version of tzdata (like
2014d, full command beinggrunt data:2014d, then run the rest of the release tasks by hand), or just apply the patch before issuing the grunt command.GHSA-56x4-j7p9-fcf9
Impact
All versions of moment-timezone from 0.1.0 contain build tasks vulnerable to command injection.
grunt data:2014d, where2014dstands for the version of the tzdata to be used from IANA's website),2014din our example), then Mallory can execute arbitrary commands on the machine running the grunt task, with the same privilege as the grunt taskAm I affected?
Do you build custom versions of moment-timezone with grunt?
If no, you're not affected.
Do you allow a third party to specify which particular version you want build?
If yes, you're vulnerable to command injection -- third party may execute arbitrary commands on the system running grunt task with the same privileges as grunt task.
Description
Command Injection via grunt-zdownload.js and MITM on iana's ftp endpoint
The
tasks/data-download.jsscript takes in a parameter from grunt and uses it to form a command line which is then executed:Ordinarily, one one run this script using something like
grunt data-download:2014d, in which case version would have the value2014d. However, if an attacker were to provide additional content on the command line, they would be able to execute arbitrary codeCommand Injection via data-zdump.js
The
tasks/data-zdump.jsscript reads a list of files present in a temporary directory (created by previous tasks), and for each one, assembles and executes a command line without sanitization. As a result, an attacker able to influence the contents of that directory could gain code execution. This attack is exacerbated by timezone data being downloaded via cleartext FTP (described above), but beyond that, an attacker at iana.org able to modify the timezone files could disrupt any systems that build moment-timezone.In this case, an attacker able to add a file to
temp/zic/2014d(for example) with a filename likeZ; curl www.example.comwould influence the called to exec on line 36 and run arbitrary code. There are a few minor challenges in exploiting this, since the string needs to be a valid filename.Command Injection via data-zic.js
Similar to the vulnerability in /tasks/data-download.js, the /tasks/data-zic.js script takes a version from the command line and uses it as part of a command line, executed without sanitization.
As a result, an attacker able to influence that string can run arbitrary commands. Of course, it requires an attacker able to influence the command passed to grunt, so may be unlikely in practice.
Patches
The supplied patch on top of 0.5.34 is applicable with minor tweaks to all affected versions. It switches
exectoexecFileso arbitrary bash fragments won't be executed any more.References
Release Notes
moment/moment-timezone (moment-timezone)
### [`v0.5.35`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0535-2022-08-23) [Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.34...0.5.35) - Fix command injection in data pipeline https://github.com/moment/moment-timezone/security/advisories/GHSA-56x4-j7p9-fcf9 - Fix cleartext transmission of sensitive information https://github.com/moment/moment-timezone/security/advisories/GHSA-v78c-4p63-2j6c Thanks to the OpenSSF Alpha-Omega project for reporting these! ### [`v0.5.34`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0534-2021-11-10) [Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.33...0.5.34) - Updated data to IANA TZDB `2021e` ### [`v0.5.33`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0533-2021-02-06) [Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.32...0.5.33) - Updated data to IANA TZDB `2021a` ### [`v0.5.32`](https://redirect.github.com/moment/moment-timezone/blob/HEAD/changelog.md#0532-2020-11-14) [Compare Source](https://redirect.github.com/moment/moment-timezone/compare/0.5.31...0.5.32) - Updated data to IANA TZDB `2020d`Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.