takari / polyglot-maven

Support alternative markup for Apache Maven POM files
Eclipse Public License 1.0
893 stars 101 forks source link

Conversion to Kotlin fails -- missing commons-lang3 #207

Open binkley opened 4 years ago

binkley commented 4 years ago
$ ./mvnw io.takari.polyglot:polyglot-translate-plugin:translate -Dinput=pom.xml -Doutput=pom.kts

produces:

$ ./mvnw io.takari.polyglot:polyglot-translate-plugin:translate   -Dinput=pom.xml -Doutput=pom.kts
[ERROR] Failed to execute goal io.takari.polyglot:polyglot-translate-plugin:0.4.4:translate (default-cli) on project kotlin-rational: Execution default-cli of goal io.takari.polyglot:polyglot-translate-plugin:0.4.4:translate failed: A required class was missing while executing io.takari.polyglot:polyglot-translate-plugin:0.4.4:translate: org/apache/commons/lang3/StringEscapeUtils

Is there a missing runtime dependency?

mosabua commented 4 years ago

Does this happen with any pom or just some specific one?

binkley commented 4 years ago

@mosabua Here is a specific project and commit:

https://github.com/binkley/spikes/commit/0dc96ab554fc298ac123eb74c3f65a7f20879051

cd scratch
./mvnw clean verify

Here is a second one:

https://github.com/binkley/kotlin-rational/commit/53b8e3536172d61e7bbf5a1feba8da1dfa00cd8c

./mvnw clean verify
mosabua commented 3 years ago

I am cutting a new release which has Kotlin 1.4.0 in it .. once that is out .. please try and let me know. I will try to get a few updates done tin the project. Maybe we can knock this one off

lievendf commented 3 years ago

Still an issue to this day, using Kotlin 1.4.10.

Adding the dependency in polyglot-translate-plugin-0.4.6.pom seems to work around the problem, but that shouldn't be needed I would think...

safeuq commented 2 years ago

Are there any updates on this? Still getting the same error.