search

takari / polyglot-maven

Support alternative markup for Apache Maven POM files
Eclipse Public License 1.0
893 stars 101 forks source link

Update Scala to 2.13.12 #278

Closed lefou closed 1 year ago

lefou commented 1 year ago

This PR updates from Scala 2.12 to 2.13. With the update to Scala 2.13.12, which is the latest available Scala 2.x version, polyglot-scala should also support Java 21.

I suggest to have this PR and PR https://github.com/takari/polyglot-maven/pull/277 (which updates from Scala 2.11 to 2.12) not in the same release, to give users of polyglot-scala a chance to migrate their builds step by step. But TBH, I have no clue how many users we still have.

Along this update, I bumped various dependencies, migrated some Scala syntax and fixed deprecated or removed API call sites. I also fixed some issues with left-open file resources.

cstamas commented 1 year ago

@lefou sorry, but I merged the other PR and now there are quite some conflicts :disappointed:

lefou commented 1 year ago

@cstamas I rebased this PR. It's ready for review and merge, although, I'd prefer if you could cut a 0.6.0 release before the merge, and a 0.7.0 release after it, due to the major change in Scala version and its potential implications for users. Thanks!

cstamas commented 1 year ago

So just to clarify:

Pls confirm

lefou commented 1 year ago

So just to clarify:

* release current master as 0.6.0

* merge this PR, release 0.7.0

Pls confirm

Exactly that. 👍‍

lefou commented 1 year ago

Thank you!