takari / takari-lifecycle

Takari Maven Lifecycle
http://takari.io/book/40-lifecycle.html
Eclipse Public License 1.0
66 stars 35 forks source link

eclipse-jdt updates and other generic fixes #104

Closed ajayk closed 2 years ago

ajayk commented 2 years ago

i didn't see this https://github.com/takari/takari-lifecycle/pull/103/

jvanzyl commented 2 years ago

I didn't see either of them, my notifications aren't setup very well. Do you want me to look at both of them together? @cstamas feel free to merge everything in, happy to give you access.

ajayk commented 2 years ago

@cstamas feel free to cherry pick the changes or close the #104

cstamas commented 2 years ago

@jvanzyl this PR requires parent changes https://github.com/takari/takari-pom/pull/9 and those need a release before this PR can carry on...

cstamas commented 2 years ago

@cstamas feel free to cherry pick the changes or close the #104

Let's merge #103 and then cherry pick whatever needed from here...

jvanzyl commented 2 years ago

Feel free to merge this if it looks good.

cstamas commented 2 years ago

Superseded by https://github.com/takari/takari-lifecycle/pull/105 (has both PRs merged)