search

takari / takari-lifecycle

Takari Maven Lifecycle
http://takari.io/book/40-lifecycle.html
Eclipse Public License 1.0
66 stars 35 forks source link

Step back to Java 8 #113

Closed cstamas closed 11 months ago

cstamas commented 1 year ago

Makes Takari Lifecycle Java8 capable. But we need some agreement about this:

@jvanzyl you had this commit in 2.0.9 (that my changes to takari POM and lifecycle propagated into 2.1.0): https://github.com/takari/takari-lifecycle/commit/e468e9a02ef9f42484f9b9831255be65969755ec

Was this the intention? As we may need latest lifecycle for polyglot that is still Java 8 (and frankly, lifecycle builds and works just nicely with Java 8).

cstamas commented 1 year ago

This PR may become fluke, if we decide to raise polyglot buildtime Java requirement, but retain runtime Java requirement (to use release=8 flag on some modules).... also, 2.0.9 and 2.1.0 are already out like this.

mosabua commented 1 year ago

I am fine with the default going back to 8, but caution that this is a default value and it could break projects that dont explicitly set it to a higher version and suddenly get compiled as 8.

Personally I think 11 is a better choice and would even support 17 ... I am a firm believer in updates..

lefou commented 1 year ago

Personally I think 11 is a better choice and would even support 17 ... I am a firm believer in updates..

I totally agree when it comes to applications. But for build tooling and libraries, where we try to provide a service to downstream users, it's a bit different story. As long as there are no (security) issues, I'd like to be as inclusive as possible.

cstamas commented 1 year ago

Having "build time java requirement" at 11 does not exclude java8 runtime. Am more and more inclined to NOT merge this... as Java 11 needed to BUILD polyglot does NOT MEANS polyglot users NEED Java 11 as well.

cstamas commented 11 months ago

This is no go, many crucial deps are moved past Java 8, closing this out