search

takari / takari-plugin-testing-project

Maven Plugin Testing Framework
Eclipse Public License 1.0
27 stars 19 forks source link

Update for Java 11 #22

Closed guw closed 4 years ago

guw commented 4 years ago

In order to build this successfully with a JDK 11 Maven and all its dependencies must be updated to a Maven version which supports JDK 11.

This also drops support for older Maven versions.

mosabua commented 4 years ago

Excellent! lgtm .. +1

wdyt @ifedorenko @jvanzyl @fbricon

ifedorenko commented 4 years ago

Are we comfortable dropping support for older Maven versions? Only supported 3.6.3 seems like a major departure from what we've done in the past, to be honest.

mosabua commented 4 years ago

I am fine with dropping older Maven versions ... however what I am wondering now is .. does this also mean older Java versions are no longer supported?

guw commented 4 years ago

Java 8 is still supported.

mosabua commented 4 years ago

Then that works for me ..

jvanzyl commented 4 years ago

Superceded by #23