Closed takasshii closed 2 years ago
val result = githubAPIRepository.getRepository( header = "application/vnd.github.v3+json", inputText = "stars" )
Error(exception=java.net.UnknownHostException: Unable to resolve host "api.github.com": No address associated with hostname)
成功したとき
2022-08-29 01:52:45.344 9179-9179/com.example.apipracticeapp V/result: Success(data=JsonGithub(items=[Content(name=starship, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/49654870?v=4), language=Rust, stargazersCount=28212, watchersCount=28212, forksCount=1183, openIssuesCount=440), Content(name=tacofancy, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/361410?v=4), language=CoffeeScript, stargazersCount=1257, watchersCount=1257, forksCount=455, openIssuesCount=13), Content(name=Starscream, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/905059?v=4), language=Swift, stargazersCount=7452, watchersCount=7452, forksCount=1048, openIssuesCount=154), Content(name=StarSpace, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/16943930?v=4), language=C++, stargazersCount=3778, watchersCount=3778, forksCount=531, openIssuesCount=54), Content(name=StarsAndClown, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/15868458?v=4), language=Python, stargazersCount=2039, watchersCount=2039, forksCount=162, openIssuesCount=7), Content(name=stars, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/25086656?v=4), language=R, stargazersCount=450, watchersCount=450, forksCount=83, openIssuesCount=21), Content(name=996.ICU, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/48942249?v=4), language=null, stargazersCount=263739, watchersCount=263739, forksCount=21517, openIssuesCount=16729), Content(name=pwc, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/2147644?v=4), language=null, stargazersCount=15406, watchersCount=15406, forksCount=2499, openIssuesCount=24), Content(name=go-web-framework-stars, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/6178510?v=4), language=Go, stargazersCount=2677, watchersCount=2677, forksCount=217, openIssuesCount=15), Content(name=pueue, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/3322822?v=4), language=Rust, stargazersCount=3062, watchersCount=3062, forksCount=82, openIssuesCount=8), Content(name=astral, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/11477125?v=4), language=PHP, stargazersCount=2889, watchersCount=2889, forksCount=137, openIssuesCount=41), Content(name=layout_stars, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/28379899?v=4), language=JavaScript, stargazersCount=0, watchersCount=0, forksCount=1579, openIssuesCount=1648), Content(name=deoplete.nvim, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/41495?v=4), language=Python, stargazersCount=5818, watchersCount=5818, forksCount=309, openIssuesCount=1), Content(name=Recent-Stars-2022, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/18531182?v=4), language=null, stargazersCount=610, watchersCount=610, forksCount=118, openIssuesCount=1), Content(name=adamalston, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/18297826?v=4), language=null, stargazersCount=110, watchersCount=110, forksCount=385, openIssuesCount=0), Content(name=DeepLearningStars, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/901975?v=4), language=Python, stargazersCount=381, watchersCount=381, forksCount=113, openIssuesCount=2), Content(name=react-stars, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/2053878?v=4), language=JavaScript, stargazersCount=195, watchersCount=195, forksCount=80, openIssuesCount=43), Content(name=starcharts, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/245435?v=4), language=Go, stargazersCount=891, watchersCount=891, forksCount=97, openIssuesCount=4), Content(name=Crypto-Signal, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/36821914?v=4), language=Python, stargazersCount=4116, watchersCount=4116, forksCount=1145, openIssuesCount=59), Content(name=stargazers, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/6147149?v=4), language=Go, stargazersCount=367, watchersCount=367, forksCount=40, openIssuesCount=11), Content(name=awesome-stars, owner=Owner(avatarUrl=https://avatars.githubusercontent.com/u/7894483?v=4), la
略
ViewModelは検証用のため、後から新しいプルリクを立てて検証します。 ↑このプルリクに含めなくてよかったかも
このプルリクに色々まとめすぎてブラックボックスになっているので、Hiltで切り出すべきでした
その他に伝えたいこと
ViewModel周りがバグの温床になっているので、できればmasterブランチにマージしたくないが、今回は一人なので黙ってマージします。ごめんなさい…
変更の概要
なぜこの変更をするのか
やったこと
変更内容
成功したとき
影響範囲
どうやるのか
略
課題
ViewModelは検証用のため、後から新しいプルリクを立てて検証します。 ↑このプルリクに含めなくてよかったかも
このプルリクに色々まとめすぎてブラックボックスになっているので、Hiltで切り出すべきでした
備考
その他に伝えたいこと