Closed takasurazeem closed 5 months ago
The project underwent updates to enhance its Quiz feature, incorporating new settings for quizzes, adjusting PDF preview functionality, and improving localization. New files were added for managing quiz settings, and the PDF generation process now utilizes these settings. Localization files were updated to support new UI elements, and the quiz view now includes a settings page. Overall, these changes aim to provide a more customizable quiz experience and streamline the preparation process for TestFlight deployments.
File(s) | Change Summary |
---|---|
Al-Tanzeel.xcodeproj/project.pbxproj |
Added QuizSettingsView.swift and QuizPreferences.swift , new group QuizSettings , and shell script build phase WhatToTest . |
QuranMajeed/Localizable.xcstrings |
Added dictionaries for emojis, "Quiz Settings" key, and placeholders for settings. |
.../Quiz/Main/View/Quiz/PDFPreviewView.swift |
Introduced AppStorage properties, updated PDFKitView structure, and utilized QuizPreferences for PDF settings. |
.../Quiz/Main/View/Quiz/QuizView.swift |
Added isShowingSettingsPage state variable for displaying settings page. |
.../Quiz/Main/ViewModel/QuizViewModel.swift |
Added import SwiftUI . |
.../Quiz/PDFPreview/Utility/PDFGenerator.swift |
Modified init to accept preferences , updated header text handling. |
.../Quiz/PDFPreview/View/QuizPDFPreview.swift |
Added quiz header preferences in struct initialization. |
QuranMajeed/Quiz/QuizSettings/QuizPreferences.swift |
Introduced QuizPreferences struct with settings for quiz header and date. |
QuranMajeed/Quiz/QuizSettings/QuizSettingsView.swift |
New view for quiz settings with UI for Masjid and Class names. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The Pull Request (PR) implements a settings menu for a quiz feature within an application. It includes the addition of new Swift files for the settings view and preferences, modifications to existing views to accommodate the settings menu, and a script to auto-generate release notes for Xcode Cloud. The settings menu allows users to customize the top header of the quiz with a Masjid name and a class name. The PR also includes localization placeholders for the new settings and updates to the PDF preview generation to reflect these preferences.
The PR seems to be well-structured with clear commit messages and purposeful changes. However, it is noted that there are some FIXME
and TODO
comments indicating that parts of the implementation are temporary and require further refinement. It is recommended to address these comments and ensure that the implementation is finalized before merging the PR. Additionally, it would be beneficial to include unit tests for the new functionality to ensure stability and prevent future regressions.
A concept settings page. الحمدالله
Summary by CodeRabbit