takaswie / linux-firewire-dkms

Currently this repository is maintained for Linux firewire subsystem and unit drivers.
http://ieee1394.docs.kernel.org/
40 stars 8 forks source link

build fails on Fedora 20 x86_64 #10

Closed nostar closed 10 years ago

nostar commented 10 years ago

$ uname -r 3.16.6-200.fc20.x86_64

Build fails as shown below, build succeeds and snd-fireworks loads and runs fine with my audiofire AF2 and AF12 after commenting out snd_card_new() as shown here:

http://pastebin.com/8UZw6Df9

make -C /lib/modules/3.16.6-200.fc20.x86_64/build M=/home/nostar/src/snd-firewire-improve modules make[1]: Entering directory /usr/src/kernels/3.16.6-200.fc20.x86_64' CC [M] /home/nostar/src/snd-firewire-improve/sound/firewire/isight.o In file included from /home/nostar/src/snd-firewire-improve/sound/firewire/isight.c:19:0: /home/nostar/src/snd-firewire-improve/sound/firewire/../../backport.h:9:59: error: static declaration of ‘snd_card_new’ follows non-static declaration static inline int snd_card_new(struct device *parent, int idx, const char *xid, ^ In file included from /home/nostar/src/snd-firewire-improve/sound/firewire/../../backport.h:4:0, from /home/nostar/src/snd-firewire-improve/sound/firewire/isight.c:19: include/sound/core.h:283:5: note: previous declaration of ‘snd_card_new’ was here int snd_card_new(struct device *parent, int idx, const char *xid, ^ In file included from /home/nostar/src/snd-firewire-improve/sound/firewire/isight.c:19:0: /home/nostar/src/snd-firewire-improve/sound/firewire/../../backport.h: In function ‘snd_card_new’: /home/nostar/src/snd-firewire-improve/sound/firewire/../../backport.h:13:2: error: implicit declaration of function ‘snd_card_create’ [-Werror=implicit-function-declaration] int err = snd_card_create(idx, xid, module, extra_size, card_ret); ^ cc1: some warnings being treated as errors make[3]: *** [/home/nostar/src/snd-firewire-improve/sound/firewire/isight.o] Error 1 make[2]: *** [/home/nostar/src/snd-firewire-improve/sound/firewire] Error 2 make[1]: *** [_module_/home/nostar/src/snd-firewire-improve] Error 2 make[1]: Leaving directory/usr/src/kernels/3.16.6-200.fc20.x86_64'

takaswie commented 10 years ago

I wonder why you build the source of this repository on Linux 3.16 because Linux 3.16 already includes this driver, snd-fireworks.

But Fedora's Linux kernel is build without CONFIG_SND_FIREWORKS. I STRONGLY recommend you to request your requirement for snd-fireworks to Fedora project, instead of building my breeding edge and asking something to me.

See: http://koji.fedoraproject.org/koji/rpminfo?rpmID=5607761

$ cat /boot/config-3.16.3-200.fc20.x86_64 ... CONFIG_SND_FIREWIRE=y CONFIG_SND_FIREWIRE_LIB=m CONFIG_SND_DICE=m CONFIG_SND_FIREWIRE_SPEAKERS=m CONFIG_SND_ISIGHT=m CONFIG_SND_SCS1X=m

CONFIG_SND_FIREWORKS is not set

CONFIG_SND_BEBOB is not set

..

Regards

takaswie commented 10 years ago

Pending till I'll move my development environment to Linux 3.16 or later. Currently I work on Ubuntu 14.04(amd64) based on Linux 3.13, to reduce my maintaining efforts.

takaswie commented 10 years ago

Fix released. Thanks. https://github.com/takaswie/snd-firewire-improve/commit/59d58c94491497776a57e8711dbf2062a0ea6c95