takcy / openid4java

Automatically exported from code.google.com/p/openid4java
Apache License 2.0
0 stars 0 forks source link

Need invalid XRDS handling #62

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
i'm using 0.9.5

1. login using http://claimid.com/success
2. XRDS location is http://claimid.com/success/xrds
3. claimID.com produce 4 <Service> elements and last 2 is invalid... see
attached file.
4. here is stacktrace 
java.lang.IllegalArgumentException: URI is not absolute
    at java.net.URI.toURL(URI.java:1080)
    at
org.openid4java.discovery.Discovery.extractDiscoveryInformation(Discovery.java:3
21)
    at org.openid4java.discovery.Discovery.discover(Discovery.java:208)
    at org.openid4java.discovery.Discovery.discover(Discovery.java:149)
    at org.openid4java.consumer.ConsumerManager.discover(ConsumerManager.java:470)
    ...

Original issue reported on code.google.com by i978suk...@gmail.com on 3 Jul 2008 at 2:48

Attachments:

GoogleCodeExporter commented 8 years ago
0.9.5 has not been released yet; what revision are you using?

The test I've added in r482 passes, relevant code is in Discovery.java:326-335 :

    try
    {
        opEndpointUrl = sepUri.getURI().toURL();
    }
    catch (MalformedURLException e)
    {
        _log.warn("Ignoring malformed OP endpoint URL in XRDS file: "
                              + sepUri.toString(), e);
        continue;
    }

Original comment by Johnny.B...@gmail.com on 3 Jul 2008 at 7:32