takcy / openid4java

Automatically exported from code.google.com/p/openid4java
Apache License 2.0
0 stars 0 forks source link

Directed identity stopped working with discovery rewrite #84

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Try to discover "openid.sapo.pt"

What is the expected output? What do you see instead?
Expected output:
Creating authentication request for OP-endpoint:
https://openid.sapo.pt/endpoint/ claimedID:
http://specs.openid.net/auth/2.0/identifier_select OP-specific ID:
http://specs.openid.net/auth/2.0/identifier_select

Worked with rev <= 528

What happens:
Creating authentication request for OP-endpoint:
https://openid.sapo.pt/endpoint/ claimedID: https://openid.sapo.pt/
OP-specific ID: https://openid.sapo.pt/

Which is wrong.

What version of the product are you using? On what operating system?
Latest rev.

Original issue reported on code.google.com by andrefcruz on 3 Feb 2009 at 12:17

GoogleCodeExporter commented 8 years ago
I'm using rev 559, and face same problem.
It seems that YadisResult sets ClamedId even when the response does not contain 
ClamedId Element.

I have found workaround. But I'm not 100% sure if this has any side effect.
YadisResult.java line 170
new UrlIdentifier(_normalizedUrl),
to
(DiscoveryInformation.OPENID2.equals(type) ? new UrlIdentifier(_normalizedUrl) 
: null),

Original comment by tomohisa...@gmail.com on 6 Feb 2009 at 8:10

GoogleCodeExporter commented 8 years ago
Won't that change leave out the discovery of OpenID 1.0/1.1 endpoints?

Original comment by andrefcruz on 9 Feb 2009 at 10:34

GoogleCodeExporter commented 8 years ago
How about:

(DiscoveryInformation.OPENID2_OP.equals(type) ? null: new 
UrlIdentifier(_normalizedUrl)),

This way only openid2 OP's are nulled.

Original comment by andrefcruz on 9 Feb 2009 at 5:16

GoogleCodeExporter commented 8 years ago
Thanks for finding and reporting this! Fixed in rev560.

Original comment by Johnny.B...@gmail.com on 14 Feb 2009 at 4:08